For calls to vscode.tasks.executeTask that use shell tasks, treat command as we treat the arguments in terms of the use of ShellQuotedString.

[jdmchp]

What it does

This pull request fixes #10805

It basically removes the limitation of a command having to be a string.
It does this by treating the command the same way as the arguments are currently treated: for ShellQuotedStrings keep the value of the command, and then later on in the backend, quote strongly.

The reason for this fix is to allow the ms-vscode.makefile-tools extension to work with Theia. This extension runs make and uses a ShellQuotedString as a command.

How to test

Try to use the ms-vscode.makefile-tools extension, it will not work. Apply the patch, it will start working.

Before the patch, any call to vscode.tasks.executeTask where a command is passed as a ShellQuotedString would fail. For example:

let myTaskOptions: vscode.ShellExecutionOptions = {env: process.env as { [key: string]: string }, cwd: "/home/jose/tmp/foo"};
const quotingStlye: vscode.ShellQuoting = vscode.ShellQuoting.Strong;
let myTaskCommand: vscode.ShellQuotedString = {value: "make with spaces", quoting: quotingStlye};
let shellExec: vscode.ShellExecution = new vscode.ShellExecution("make with spaces", myTaskOptions);
let myTask: vscode.Task = new vscode.Task({type: "shell", group: "build", label: "my label"},
vscode.TaskScope.Workspace, "makefileBuildTaskName", "makefile", shellExec);

myTask.problemMatchers = [];
myTask.presentationOptions.showReuseMessage = true;

await vscode.tasks.executeTask(myTask);

would fail with:

throw new Error('Converting ShellQuotedString command is not implemented');

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines
  Commands with spaces, for example, now can be passed to executeTask and they will work OK in windows or *nix.

[vince-fugnitto]

@jdmchp thank you for your first contribution to the project!

Please be sure to address the test failures introduced with the changes and we will review shortly afterwards :)

[vince-fugnitto]

The changes work well for me, I confirmed that it works when using my custom extension
(shell-quote-0.0.1.zip). I only have minor commands about the code.

[jdmchp]

Hello @vince-fugnitto , I pushed changes using the feedback you gave me.
Please let me know if more work is needed. Thanks.

[vince-fugnitto]

@jdmchp thank you for your patience and first contribution to the project! :)