Restore selection
in Monaco editor options
#11049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11017 by restoring the logic to extract the selection from the options passed to the
MonacoEditorService
. Previously, the relevant fields had been added to theIResourceEditorInput
declaration in ourmonaco.d.ts
, but in fact they come from an extension of that interface, theITextResourceEditorInput
. The new code checks whether the input we're dealing with satisfies the latter and extracts the selection if possible.How to test
ctrl+click
on variables / methods imported from / defined in other files.Review checklist
Reminder for reviewers