quality: remove duplicate header from a ts file #11058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangameshItagi
force-pushed
the
bugfix/remove-duplicate-header
branch
from
da70d2f to
d3339ba
Compare
There was a problem hiding this comment.
@SangameshItagi thank you for the contribution!
There is a minor issue left regarding linting then we can merge.
Signed-off-by: Sangamesh Itagi <[email protected]>
SangameshItagi
force-pushed
the
bugfix/remove-duplicate-header
branch
from
d3339ba to
86b12bb
Compare
|
@vince-fugnitto Thanks for the review. Have removed the extra line. |
vince-fugnitto
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
@SangameshItagi thank you for your first contribution to the project :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11056
Removed the duplicate header that was present in the packages/core/src/common/quick-pick-service.ts file.
Please tell me if there is anything I may need to change! Thank you and welcome the feedback.