Add errors handling for plugins downloading #11454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11260.
Catches and collects errors that occur when loading plugins. This allows to try to load all plugins and not terminate the load after the first fail. Does not interact with the user (what was suggested in the issue), because the loading of plugins goes in parallel and, as a consequence, it is difficult to stop loading if the user wants to.
How to test
Run
yarn download:plugins --api-url https://google.com
-- plugins downloading is failed. Before the change you get an error after loading the first plugin. After the change, you should see attempts to load all plugins.Review checklist
Reminder for reviewers