Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors handling for plugins downloading #11454

Merged

Conversation

pluralia
Copy link
Contributor

What it does

Closes #11260.
Catches and collects errors that occur when loading plugins. This allows to try to load all plugins and not terminate the load after the first fail. Does not interact with the user (what was suggested in the issue), because the loading of plugins goes in parallel and, as a consequence, it is difficult to stop loading if the user wants to.

How to test

Run yarn download:plugins --api-url https://google.com -- plugins downloading is failed. Before the change you get an error after loading the first plugin. After the change, you should see attempts to load all plugins.

Review checklist

Reminder for reviewers

@msujew msujew added the vsx-registry Issues related to Open VSX Registry Integration label Jul 22, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected 👍

@vince-fugnitto vince-fugnitto merged commit d293127 into eclipse-theia:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle unexpected Open VSX responses more gracefully
3 participants