Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] upgrade electron/get to 2.0.0 #11573

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

danepowell
Copy link
Contributor

What it does

In the ffmpeg package, upgrade electron/get to the latest version (2.0.0) so that downstream projects can run a secure version of got (^11.8.5)

How to test

This should have no functional changes except to drop Node 12 support, which is already less than what Theia supports: electron/get#225

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Aug 16, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

In addition, please be sure to also build the changes (yarn) as it should cause our yarn.lock file to be updated.

theia/yarn.lock

Lines 923 to 924 in c26f12e

"@electron/get@^1.12.4", "@electron/get@^1.13.0":
version "1.14.1"

@danepowell
Copy link
Contributor Author

Done, thanks. I didn't see that yarn.lock was in a different directory.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update 👍

I confirmed that the build is successful, ffmpeg is successfully replaced (no proprietary codecs found), and yarn audit | grep "@electron/get" no longer outputs the got vulnerability.

@vince-fugnitto vince-fugnitto merged commit 8706ed8 into eclipse-theia:master Aug 18, 2022
@vince-fugnitto vince-fugnitto added this to the 1.29.0 milestone Aug 25, 2022
@vince-fugnitto vince-fugnitto added the react issues related to the react language label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file react issues related to the react language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants