Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: fix the selected channel name #11727

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

inlann
Copy link
Contributor

@inlann inlann commented Sep 30, 2022

What it does

Fix the channel selector of the output view toolbar. Let the selector automatically switch to the selected channel name based on the current channel name.

How to test

  1. Create a class at the frontend and inject the OutputChannelManager
  2. Get a channel using `this.outputChannelManager.getChannel('Test Channel')
  3. Show the channel and push some message into it using channel.show() and channel.appendLine('test message', OutputChannelSeverity.Info)
  4. The output view will show the message but the channel selector does not switch to the Test Channel.
  5. This pull request fixes the channel selector and lets it automatically switch to the selected channel name based on the current channel name.

Review checklist

Reminder for reviewers

Let the channel selector automatically switch to the selected channel name based on the current channel name.
@inlann inlann changed the title [output] Fix the channel selector. [Output] Fix the channel selector. Sep 30, 2022
@vince-fugnitto vince-fugnitto added the output issues related to the output label Sep 30, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍
I confirm that the changes work as expected, the toolbar properly updates it's name.

@vince-fugnitto vince-fugnitto changed the title [Output] Fix the channel selector. output: fix the selected channel name Sep 30, 2022
@vince-fugnitto vince-fugnitto merged commit 89df935 into eclipse-theia:master Oct 4, 2022
@vince-fugnitto vince-fugnitto added this to the 1.31.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output issues related to the output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants