Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register VSCode items directly with corresponding internal menus #11741

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Register VSCode items directly with corresponding internal menus #11741

merged 4 commits into from
Oct 13, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Oct 6, 2022 •
edited
Loading

What it does

Fixes #11735

How to test

  1. Install this plugin. (Source)
  2. Open a plugin tree view, e.g. the built-in NPM view.
  3. Observe that a thumbs-up or thumbs-down icon is rendered on each item (in addition to run and debug options, for most).
  4. Click it.
  5. Observe that it changes immediately to the other direction.
  1. Observe that other menu items appear in the correct locations, according to Refactor PluginMenuContributionHandler #11290.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added vscode issues related to VSCode compatibility menus issues related to the menu labels Oct 6, 2022
@colin-grant-work colin-grant-work mentioned this pull request Oct 6, 2022
Merged
1 task
vince-fugnitto
vince-fugnitto approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me and the code looks good 👍

@colin-grant-work colin-grant-work merged commit 901364c into eclipse-theia:master Oct 13, 2022
@colin-grant-work colin-grant-work deleted the bugfix/tree-view-menus branch October 13, 2022 13:58
@vince-fugnitto vince-fugnitto added this to the 1.31.0 milestone Oct 27, 2022
erezmus pushed a commit to ARMmbed/theia that referenced this pull request May 5, 2023
@erezmus
Register VSCode items directly with corresponding internal menus (ecl…
00e78d4 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
@erezmus erezmus mentioned this pull request May 5, 2023
Closed
1 task
erezmus pushed a commit to ARMmbed/theia that referenced this pull request May 11, 2023
@erezmus
Register VSCode items directly with corresponding internal menus (ecl…
e66f972 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Jun 12, 2023
@erezmus
Register VSCode items directly with corresponding internal menus (ecl…
70e8d45 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 22, 2023
@CareyJWilliams
Register VSCode items directly with corresponding internal menus (ecl…
5bd831b 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 23, 2023
@CareyJWilliams
Register VSCode items directly with corresponding internal menus (ecl…
f64b908 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Sep 4, 2023
@erezmus
Register VSCode items directly with corresponding internal menus (ecl…
c9271f3 
…ipse-theia#11741)

Fixes bug where inline items were not appearing in TreeViews.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
menus issues related to the menu vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.

Tree view inline commands not working
2 participants
@colin-grant-work @vince-fugnitto