Use environment-safe platform check in preferences #11888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thegecko <[email protected]>
msujew
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Looks reasonable to me 👍
I'm wondering whether it makes sense to grab the backend OS type instead since we are dealing with URIs. I saw that we never set the backend OS type in the web-based plugin host, so it will always be populated with the frontend OS type. We might want to address this in a follow-up PR.
|
Apologies for introducing the bad dependency, and thanks for the fix! |
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
May 15, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 12, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 22, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 23, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Aug 2, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Sep 4, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Sep 12, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Sep 21, 2023
Signed-off-by: thegecko <[email protected]> Signed-off-by: thegecko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: thegecko [email protected]
What it does
The PR: #11393
Introduced a dependency on the node
osmodule in common plugin source. This had the effect that the preferences system doesn't load for web-based extensions.This PR fixes the issue by using the environment-safe checks instead.
How to test
Load a web extension which accesses user configuration and check it is possible.
Review checklist
Reminder for reviewers