Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove watch expressions one by one #11956

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Dec 5, 2022

What it does

I noticed in #11953 that watch expressions can only be removed in bulk. This change aligns the UX to vscode, where users are able to remove watched expressions one by one.

Also fixes an existing issue where watched expressions which evaluate to an object result in an overflow:

image

How to test

  1. Start debugging a Test in Theia
  2. Add multiple watched expressions
  3. Confirm that they can be removed one by one

image

I believe the theia-tree-element-node css class is reused in the debug console to display evaluated expressions. Assert that no regressions appeared due to my changes.

Review checklist

Reminder for reviewers

@msujew msujew added debug issues that related to debug functionality ui/ux issues related to user interface / user experience labels Dec 5, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msujew I believe we might want to improve the styling by:

  • only showing the remove expression icon on hover (similarly to vscode)
  • aligning the icon with the row

image

@msujew
Copy link
Member Author

msujew commented Dec 5, 2022

@vince-fugnitto Thanks, didn't notice these two differences. Funnily enough, vscode's button also isn't correctly vertically centered with the row :D

image

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and I confirm that we can now discard individual watch expressions 👍

packages/core/src/browser/style/tree.css Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants