Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trash dependency to 7.2.0 #12133

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 1, 2023

What it does

Updates our trash dependency. Doesn't update to latest (8.1.0), since trash has moved to ESM with version 8.0.0. The current version still pulls uuid version 3.4.0, which is deprecated by now. Related to #12131.

How to test

Open Theia as an Electron app and delete a file in the navigator. The file should still be correctly moved to the system trash.

Review checklist

Reminder for reviewers

@msujew msujew added the dependencies pull requests that update a dependency file label Feb 1, 2023
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trash functionality still works.

@paul-marechal paul-marechal merged commit 2663bbc into master Feb 2, 2023
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 2, 2023
@msujew msujew deleted the msujew/update-trash-dep branch February 3, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants