Align terminal command ids with VS Code. Fixes #12084 #12134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
|
Here's the extension: and the source: |
|
@vince-fugnitto the promised follow-up to #12066 |
msujew
reviewed
Feb 1, 2023
tsmaeder
force-pushed
the
12084_align_terminal_commands
branch
from
89b4bfa
to
135e389
Compare
vince-fugnitto
added
terminal
vince-fugnitto
approved these changes
Feb 2, 2023
Signed-off-by: Thomas Mäder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR aligns the command ids of commands related to terminals with their counterparts in VS Code.
The change includes a "drive-by" fix for the file open dialog that I needed for testing "Open in Terminal".
Fixes #12084
Contributed on behalf of STMicroelectronics
How to test
The attached extension contributes commands that invokes each terminal command via its VS Code id.
Review checklist
Reminder for reviewers