Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workbench.editor.revealIfOpen preference #12145

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Feb 3, 2023

What it does

Implements the workbench.editor.revealIfOpen preference.

How to test

  1. By default the preference should be false. That means that if you open a file, it should by default open on the active tabbar even if you already have an editor open for that file on another tabbar.
  2. If you set the preference to true, an existing editor for a file should be revealed if it is present, even if it is present on another tab than the current active tab.

Note that it should be revealed; it may not be focused, so if you e.g. click from the explorer to open the file, the explorer may remain focused unless you double click. That appears to be consistent with VCode's behavior, though I'm open to defaulting to activating in that case.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added preferences issues related to preferences editor issues related to the editor labels Feb 3, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • if the preference is false the editor will open in the active tabbar if it can
  • if the preference is true the editor will be revealed if it is already open in a tabbar

@colin-grant-work colin-grant-work merged commit 423b14b into eclipse-theia:master Feb 6, 2023
@colin-grant-work colin-grant-work deleted the feature/workbench-reveal-preference branch February 6, 2023 20:45
@colin-grant-work colin-grant-work added this to the 1.35.0 milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants