Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set http proxy default to off for browser #12267

Closed
wants to merge 1 commit into from

Conversation

thegecko
Copy link
Member

@thegecko thegecko commented Mar 8, 2023

What it does

With reference to #11911, it was suggested to set the http proxy default setting for browsers to off.

How to test

Open a browser app and confirm the http.proxySupport setting defaults to off. Electron apps should still default to override

Review checklist

Reminder for reviewers

@thegecko thegecko requested a review from msujew March 8, 2023 03:30
@msujew
Copy link
Member

msujew commented Mar 8, 2023

I would first like to see whether #12266 fixes the issue for users instead of turning the feature off. I believe as it stands, the feature is kind of fundamentally broken, but my PR should address this.

@thegecko
Copy link
Member Author

thegecko commented Mar 8, 2023

I would first like to see whether #12266 fixes the issue for users instead of turning the feature off

I was under the impression this feature makes less sense in the browser version and the proxy is for electron apps. Am I mistaken?

@msujew
Copy link
Member

msujew commented Mar 8, 2023

@thegecko It makes a bit less sense in the browser version of Theia, but it's still useful. Ideally, using override (or therefore any other value than off) shouldn't impact the functionality of the application at all. That's what my PR is for.

@thegecko
Copy link
Member Author

thegecko commented Mar 8, 2023

Ok, feel free to close this PR :)

@msujew msujew mentioned this pull request Mar 8, 2023
1 task
@thegecko thegecko closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants