In MonacoEditorModel, use value for snapshot #12418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12406 by changing the snapshotting logic in
MonacoEditorModel
It turns out that the brand of
ITextModel
that we use in Monaco has this size restriction on its snapshots:https://github.com/microsoft/vscode/blob/7bd1368261677fa160c28ff043c444d905331ee7/src/vs/editor/common/model/textModel.ts#L155-L157
That means that in general, we want to use the value rather than delegating to that implementation of
createSnapshot
.How to test
Review checklist
Reminder for reviewers