Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: fix launch configurations for ovsx #12731

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request fixes the launch configurations when referencing ovsx-router-config.json to use the proper path with respect to the workspaceFolder.

How to test

  1. confirm that both Launch Browser Backend & Frontend and `Launch Electron Backend & Frontend debug configurations work as expected

Review checklist

Reminder for reviewers

The commit fixes the launch configurations when referencing
`ovsx-router-config.json` to use the proper path with respect to
the `workspaceFolder`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Jul 19, 2023
@vince-fugnitto vince-fugnitto merged commit 2b4fb4b into master Jul 24, 2023
@vince-fugnitto vince-fugnitto deleted the vf/fix-launch branch July 24, 2023 14:10
@github-actions github-actions bot added this to the 1.40.0 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants