plugin-ext: default the folderExpanded icon #12776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Jul 31, 2023
packages/plugin-ext/src/main/browser/plugin-icon-theme-service.ts
Outdated
Show resolved
Hide resolved
In file icon themes, VS Code will use the "folder" icon also for expanded folders in the case that the theme omits the "folderExpanded" entry. Theia should do the same for consistency. Fixes eclipse-theia#12727 Signed-off-by: Christian W. Damus <[email protected]>
|
@cdamus Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In file icon themes, VS Code will use the
"folder"icon also for expanded folders in the case that the theme omits the"folderExpanded"entry.This PR implements the same fall-back in Theia for consistency.
Fixes #12727
How to test
myextextension with a custom file icon theme.myextextension package into yourplugins/folder.Furthermore, edit the file icon theme in the
myexttoresources/conveniently includes additional icons) as the"folderExpanded"and see that it works as expected, showing that icon in expanded state and the other in collapsed state"folderExpanded": nullor"folderExpanded": ""to explicitly ask for no icon for expanded state and see that this also worksReview checklist
Reminder for reviewers