-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly re-render problem widget and fix problem matching #12802
Conversation
2236e67
to
dfd31ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've tested on Windows and Linux.
There is no need to resize the problem view anymore. Also the encoding issue in the filename is fixed.
However the bug report also mentions ERROR Request resize failed with error: Cannot resize a pty that has already exited Error: Cannot resize a pty that has already exited
.
I am still seeing this on Windows.
@jfaltermeier Thanks! I'll look into this and see if there is something I can do. |
fd122db
to
bfbe898
Compare
- Ensure we re-render the tree model if the problem widget is activated - Update Ansi stripping to catch Windows 'clear screen' and other codes - Consistently use Theia URI in problem matcher protocol - Report exit status to terminal widget to avoid resize warning #12724
bfbe898
to
f636e68
Compare
@jfaltermeier That was actually quite a messy one but I think I found a good solution based on how VS Code handles the terminals in Windows. Could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm now!
What it does
Fixes #12724
How to test
(Windows)
(File path on Hover)
(Linux)
Review checklist
Reminder for reviewers