Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly re-render problem widget and fix problem matching #12802

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at martin-fleck-at commented Aug 7, 2023

What it does

  • Ensure we re-render the tree model if the problem widget is activated
  • Update Ansi stripping to catch Windows 'clear screen' and other codes
  • Consistently use Theia URI in problem matcher protocol

Fixes #12724

How to test

{
   "version": "2.0.0",
   "tasks": [
      {
         "label": "echo",
         "type": "shell",
         "command": "@echo somefile.abc:1:4: warning: the roof is on fire ",
         "problemMatcher" : ["$myproblemmatcher"]
      }
   ]
}
  • Run Task 'echo' and check the Problems view:

image
(Windows)

image
(File path on Hover)

image
(Linux)

Review checklist

Reminder for reviewers

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've tested on Windows and Linux.
There is no need to resize the problem view anymore. Also the encoding issue in the filename is fixed.

However the bug report also mentions ERROR Request resize failed with error: Cannot resize a pty that has already exited Error: Cannot resize a pty that has already exited.
I am still seeing this on Windows.

@martin-fleck-at
Copy link
Contributor Author

@jfaltermeier Thanks! I'll look into this and see if there is something I can do.

@martin-fleck-at martin-fleck-at force-pushed the martin-fleck-at/12724 branch 5 times, most recently from fd122db to bfbe898 Compare August 9, 2023 15:10
- Ensure we re-render the tree model if the problem widget is activated
- Update Ansi stripping to catch Windows 'clear screen' and other codes
- Consistently use Theia URI in problem matcher protocol

- Report exit status to terminal widget to avoid resize warning

#12724
@martin-fleck-at
Copy link
Contributor Author

@jfaltermeier That was actually quite a messy one but I think I found a good solution based on how VS Code handles the terminals in Windows. Could you please have another look?

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm now!

@martin-fleck-at
Copy link
Contributor Author

@tsmaeder @msujew Since you guys also worked on the terminal, do you wanna have another look at this? Since the change is not that small, another pair of eyes might provide additional insights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problems issues related to the problems widget
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Problems View fails to show new problems until you alter the horizontal size of the app window
3 participants