Style: close icon highlights on tab hover #12806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a small issue where the close icon is highlighted when mouse hovers over tab instead of over button only. Signed-By: Fernando Ascencio <[email protected]>
msujew
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit brings the mouse onHover behavior on tabs closer to VS Code behavior.
Currently:
On VS Code:
This request:
I have kept the lines in
tabs.cssdespite them seemingly being obsolete. The function of the style implemented in lines 256-261 seems to be redundant as eliminating them caused no visible change in the styling.How to test
Review checklist
Reminder for reviewers