-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsx-registry: add hint to fetching extensions error #12858
Conversation
72b82e3
to
2aac771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good to me. @vince-fugnitto your opinion?
Seems fine to me as well, there will be a trailing whitespace in the header if the error is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'd be fine with merging this then. @SamuelBergSTM do you mind updating the changelog to correctly reflect this change? I'll merge this afterwards.
I can update the changelog message, yes. |
Clarifies the error by suggesting it could be caused by network configuration issues. Contributed by STMicroelectronics Signed-off-by: Samuel BERG <[email protected]>
Contributed by STMicroelectronics Signed-off-by: Samuel BERG <[email protected]>
Clarifies that it concerns specifically ENOTFOUND errors Contributed by STMicroelectronics Signed-off-by: Samuel BERG <[email protected]>
73b9b1a
to
ba7ab2d
Compare
@SamuelBergSTM You've added the changelog entry to 1.41 which was released last month. Please update it to 1.42. |
Contributed by STMicroelectronics Signed-off-by: Samuel BERG <[email protected]>
@msujew Good catch. I overlooked this. I created a new v1.42.0 heading and placed the entry there. Does this look OK? |
What it does
When browsing the VSX registry while having network configuration issues (e.g. proxy issues), the error message is a bit vague. E.g:
"Error fetching extensions. getaddrinfo ENOTFOUND open-vsx.org"
This PR addresses the issue by changing the user message to the following:
"Error fetching extensions. getaddrinfo ENOTFOUND open-vsx.org This could be caused by network configuration issues."
Clarifies the error by suggesting it could be caused by network configuration issues.
Contributed by STMicroelectronics
Signed-off-by: Samuel BERG [email protected]
How to test
C:\Windows\System32\drivers\etc\hosts
(Windows) //etc/hosts
(Linux).Option A: Launch a Theia example with an invalid ovsx-router-config path (e.g.
--ovsx-router-config=invalid-path
) to exclude the local mock VSX registry.Option B: Launch Theia Blueprint as-is.
Extensions
view."Error fetching extensions. {ERROR} {IP_ADDRESS} This could be caused by network configuration issues."
Review checklist
Reminder for reviewers