Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsx-registry: add hint to fetching extensions error #12858

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

SamuelBergSTM
Copy link
Contributor

What it does

When browsing the VSX registry while having network configuration issues (e.g. proxy issues), the error message is a bit vague. E.g:
"Error fetching extensions. getaddrinfo ENOTFOUND open-vsx.org"

This PR addresses the issue by changing the user message to the following:
"Error fetching extensions. getaddrinfo ENOTFOUND open-vsx.org This could be caused by network configuration issues."

Clarifies the error by suggesting it could be caused by network configuration issues.

Contributed by STMicroelectronics
Signed-off-by: Samuel BERG [email protected]

How to test

  1. Produce a network issue. E.g. adding the line "127.0.0.1 open-vsx.org" to C:\Windows\System32\drivers\etc\hosts (Windows) / /etc/hosts (Linux).
  2. Launch a Theia application.
    Option A: Launch a Theia example with an invalid ovsx-router-config path (e.g. --ovsx-router-config=invalid-path) to exclude the local mock VSX registry.
    Option B: Launch Theia Blueprint as-is.
  3. Open the Extensions view.
  4. Enter a search term (e.g. "C++").
  5. Ensure that the error message is the following:
    "Error fetching extensions. {ERROR} {IP_ADDRESS} This could be caused by network configuration issues."

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the vsx-registry Issues related to Open VSX Registry Integration label Aug 24, 2023
packages/core/i18n/nls.json Outdated Show resolved Hide resolved
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me. @vince-fugnitto your opinion?

@vince-fugnitto
Copy link
Member

Looks quite good to me. @vince-fugnitto your opinion?

Seems fine to me as well, there will be a trailing whitespace in the header if the error is not ENOTFOUND but it should be fine.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'd be fine with merging this then. @SamuelBergSTM do you mind updating the changelog to correctly reflect this change? I'll merge this afterwards.

@SamuelBergSTM
Copy link
Contributor Author

Alright, I'd be fine with merging this then. @SamuelBergSTM do you mind updating the changelog to correctly reflect this change? I'll merge this afterwards.

I can update the changelog message, yes.
I will also rebase since there are now conflicts in the changelog.

Clarifies the error by suggesting it could be caused by network configuration issues.

Contributed by STMicroelectronics
Signed-off-by: Samuel BERG <[email protected]>
Contributed by STMicroelectronics
Signed-off-by: Samuel BERG <[email protected]>
Clarifies that it concerns specifically ENOTFOUND errors

Contributed by STMicroelectronics
Signed-off-by: Samuel BERG <[email protected]>
@msujew
Copy link
Member

msujew commented Sep 20, 2023

@SamuelBergSTM You've added the changelog entry to 1.41 which was released last month. Please update it to 1.42.

Contributed by STMicroelectronics
Signed-off-by: Samuel BERG <[email protected]>
@SamuelBergSTM
Copy link
Contributor Author

@SamuelBergSTM You've added the changelog entry to 1.41 which was released last month. Please update it to 1.42.

@msujew Good catch. I overlooked this. I created a new v1.42.0 heading and placed the entry there. Does this look OK?

@msujew msujew merged commit 03d0cb8 into eclipse-theia:master Sep 20, 2023
12 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants