-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump API version to 1.80.0 #12866
Bump API version to 1.80.0 #12866
Conversation
Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a short check with the 1.79 built-ins.
The only thing I noticed is that the toolbar for markdown files shows two "Open Preview to the side" items, one of them showing the shortcut as well. But it looks like this was reproducible for 1.40 as well. Is this known already?
Otherwise I also installed the vsix-es from the PRs for the new VSCode API and those work as well.
which PR is that? |
🤷 |
@jfaltermeier I believe it's expected, since we have a preview command for markdown files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ref: eclipse-theia/theia#12866 Signed-off-by: Akos Kitta <[email protected]>
Ref: eclipse-theia/theia#12866 Signed-off-by: Akos Kitta <[email protected]>
Contributed on behalf of ST Microelectronics
What it does
fixes #12865
How to test
Make sure the system starts and built-ins work as expected
Review checklist
Reminder for reviewers