Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiline searches #12868

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Add support for multiline searches #12868

merged 11 commits into from
Sep 25, 2023

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Aug 28, 2023 •
edited by vince-fugnitto
Loading

What it does

Fixes #11656

How to test

Open the same folder in both Theia and VSCode, search for the same multiline string and compare.

Review checklist

Reminder for reviewers

vince-fugnitto
vince-fugnitto reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the chance to test completely yet, but the styling is broken compared to the behavior on master where we can see the icons for search options (match-case, include ignored files, etc.) when view size is smaller:

image

@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Aug 28, 2023
@KR155E
Dynamic textarea resize
d992683 
Signed-off-by: Christian Radke <[email protected]>
@KR155E
Copy link
Contributor Author

KR155E commented Aug 28, 2023

Thanks for the feedback! Please pull again, I have pushed a fix for the issue.

msujew
msujew reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a minor visual regression in the search widget related to the margin and height of the search detail inputs:

this PR

image

before
image

@KR155E
Copy link
Contributor Author

KR155E commented Sep 11, 2023

Well spotted, thanks! Had to do with the move to react-autosize-textarea. I have updated the CSS to fix the regression.

msujew
msujew reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good functionally. I just have two comments, see below.

packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx Outdated Show resolved Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx Outdated Show resolved Hide resolved
msujew
msujew approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@msujew msujew merged commit f038673 into eclipse-theia:master Sep 25, 2023
12 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
@kittaakos kittaakos mentioned this pull request Oct 13, 2023
Closed
4 tasks
@KR155E KR155E mentioned this pull request Nov 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto left review comments

@kittaakos kittaakos kittaakos left review comments

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace
Projects
PR Backlog
Archived in project
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.

search-in-workspace: add support for multi-line searches
4 participants
@KR155E @kittaakos @msujew @vince-fugnitto