Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-textmate dependency #12963

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Sep 30, 2023

What it does

Closes #12960.

Updates our vscode-textmate dependency to fix an issue in plist xml parsing that only seems to appear in newer versions of Chrome.

How to test

  1. Open Theia in Chrome (version >= 117.0)
  2. Install the Twig Language extension.
  3. Open a .twig file, the highlighting should work as expected:
{% for user in users %}
* {{ user.name }}
{% else %}
No users have been found.
{% endfor %}

Review checklist

Reminder for reviewers

@msujew msujew added monaco issues related to monaco dependencies pull requests that update a dependency file labels Sep 30, 2023
@rahulgupta-acquia
Copy link

@msujew this PR will resolve the Chrome 117 twigg color coding issue?

@msujew
Copy link
Member Author

msujew commented Oct 1, 2023

@rahulgupta-acquia Yes, it explicitly says so in the testing instructions.

Note that this change will only get released in a month. You can set a resolution for vscode textmate to 9.0.0 in your project, and that should work as well.

@rahulgupta-acquia
Copy link

Thanks @msujew

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit 4c8a64d into master Oct 3, 2023
12 checks passed
@msujew msujew deleted the msujew/update-vscode-textmate branch October 3, 2023 13:07
@github-actions github-actions bot added this to the 1.43.0 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file monaco issues related to monaco
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Color Coding not working in Twig files in Chrome Browser 117.0.5938.132
3 participants