Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tree data providers to return null items #13018

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 22, 2023

What it does

Closes #13001

Some extensions return falsy values in their tree data providers. VSCode first filters the results by using coalesce. This change aligns Theia to the behavior of vscode to also allow falsy values.

How to test

  1. Install the SonarLint extension from open-vsx
  2. Open the SonarLint Issues Location view in the explorer panel
  3. Assert that the welcome view info is shown and no error is logged on the backend.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the changes work as expected, and fixes the error 👍

@vince-fugnitto vince-fugnitto merged commit 8cb8268 into master Oct 26, 2023
13 checks passed
@vince-fugnitto vince-fugnitto deleted the msujew/null-tree-item branch October 26, 2023 17:58
@vince-fugnitto vince-fugnitto modified the milestone: 1.43.0 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading 'label') in TreeViewExtImpl.getTreeItemLabel
2 participants