fix: allow all listener to be executed for AsyncEmitter #13079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
With AsyncEmitters, if a listener callback does not call
event.waitUntil
, other listeners that are registered after this one will fail to be called due to early loop termination.How to test
Register two separate callbacks without
waitUntil
forFileService.onDidRunUserOperation
or any otherAsyncEmitter.event
and fire an event. Verify that both callbacks are called correctly.Review checklist
Reminder for reviewers