Make sure we can reopen secondary windows #13509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
There were two problems:
Fixes #13214
Contributred on behalf of STMicroelectronics.
How to test
Open and close secondary windows in both the browser and electron case. Make sure there are no exceptions and documents can be reopened. I used the
hediet.vscode-drawio
extension from open-vsx to test.Follow-ups
Review checklist
Reminder for reviewers