Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alot more keybings to the notebook editor #13594

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Apr 11, 2024

What it does

This adds multiple new keybindings and some commands and preferences to the notebook editor that vscode supports as well:

  • ctrl+x cut cell

  • ctrl+c copy cell

  • ctrl+v paste cell

  • Enter (new for code cells) focus editor

  • Esc unfocus editor/stop markdown edit

  • linenumber preference to activate and deactivate line numbers in cell editors

  • collapse/expand cell ouptut command

How to test

Open a notebook and test the new commands

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden requested a review from msujew April 11, 2024 12:14
Signed-off-by: Jonah Iden <[email protected]>
@jonah-iden jonah-iden requested a review from msujew April 11, 2024 14:24
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me after the latest changes 👍

@jonah-iden jonah-iden merged commit 16982d3 into master Apr 11, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/notebook-more-keybindings branch April 11, 2024 15:38
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 11, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants