Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional css to notebook output webviews #13666

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Added additional css to notebook output webviews #13666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23bdbb
Added additional css to notebook ooutput webviews
jonah-iden Apr 29, 2024
4810897
renamed symbol to be more descriptive
jonah-iden Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 74 additions & 1 deletion packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,82 @@ import { NotebookModel } from '@theia/notebook/lib/browser/view-model/notebook-m

const CellModel = Symbol('CellModel');
const Notebook = Symbol('NotebookModel');
export const AdditionalNotebookCellOutputCss = Symbol('AdditionalNotebookCellOutputCss');

export function createCellOutputWebviewContainer(ctx: interfaces.Container, cell: NotebookCellModel, notebook: NotebookModel): interfaces.Container {
const child = ctx.createChild();
child.bind(CellModel).toConstantValue(cell);
child.bind(Notebook).toConstantValue(notebook);
child.bind(AdditionalNotebookCellOutputCss).toConstantValue(DEFAULT_NOTEBOOK_OUTPUT_CSS);
child.bind(CellOutputWebviewImpl).toSelf().inSingletonScope();
return child;
}

export const DEFAULT_NOTEBOOK_OUTPUT_CSS = `
table {
border-collapse: collapse;
border-spacing: 0;
}

table th,
table td {
border: 1px solid;
}

table > thead > tr > th {
text-align: left;
border-bottom: 1px solid;
}

table > thead > tr > th,
table > thead > tr > td,
table > tbody > tr > th,
table > tbody > tr > td {
padding: 5px 10px;
}

table > tbody > tr + tr > td {
border-top: 1px solid;
}

table,
thead,
tr,
th,
td,
tbody {
border: none !important;
border-color: transparent;
border-spacing: 0;
border-collapse: collapse;
}

table,
th,
tr {
vertical-align: middle;
text-align: right;
}

thead {
font-weight: bold;
background-color: rgba(130, 130, 130, 0.16);
}

th,
td {
padding: 4px 8px;
}

tr:nth-child(even) {
background-color: rgba(130, 130, 130, 0.08);
}

tbody th {
font-weight: normal;
}
`;

@injectable()
export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {

Expand Down Expand Up @@ -77,6 +144,9 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
@inject(QuickPickService)
protected readonly quickPickService: QuickPickService;

@inject(AdditionalNotebookCellOutputCss)
protected readonly additionalOutputCss: string;

readonly id = generateUuid();

protected editor: NotebookEditorWidget | undefined;
Expand Down Expand Up @@ -129,7 +199,7 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
'jupyter.viewOutput',
'workbench.action.openLargeOutput',
'cellOutput.enableScrolling',
]
],
});
this.webviewWidget.setHTML(await this.createWebviewContent());

Expand Down Expand Up @@ -236,6 +306,9 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
<html>
<head>
<meta charset="UTF-8">
<style>
${this.additionalOutputCss}
</style>
</head>
<body>
<script type="module">${preloads}</script>
Expand Down
Loading