feat(ai): Improve styling of the chat widget #14278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
approved these changes
Oct 10, 2024
| @@ -128,7 +128,7 @@ const CopyToClipboardButton = (props: { code: string, clipboardService: Clipboar | |||
| const copyCodeToClipboard = React.useCallback(() => { | |||
| clipboardService.writeText(code); | |||
| }, [code, clipboardService]); | |||
| return <button className='theia-button main' onClick={copyCodeToClipboard}>Copy</button>; | |||
| return <div className='button codicon codicon-copy' title='Copy' onClick={copyCodeToClipboard}></div>; | |||
There was a problem hiding this comment.
we should add role='button' for accessibility reasons
| @@ -150,7 +150,7 @@ const InsertCodeAtCursorButton = (props: { code: string, editorManager: EditorMa | |||
| }]); | |||
| } | |||
| }, [code, editorManager]); | |||
| return <button className='theia-button main' onClick={insertCode}>Insert at Cursor</button>; | |||
| return <div className='button codicon codicon-insert' title='Insert at Cursor' onClick={insertCode}></div>; | |||
* General improvements of margins and paddings * Give code a nicer border and more space * Replace aggressive buttons for code parts with more subtle icons * Format tool call result more nicely Contributed on behalf of STMicroelectronics
planger
force-pushed
the
ai-improve-chat-styling
branch
from
d810384 to
f2b2e61
Compare
sdirix
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Contributed on behalf of STMicroelectronics
How to test
Use the chat view and let an LLM generate some code, bullet list (ordered, unordered), use tool functions and check if all looks better than before.
Follow-ups
The code content part renderer could still be improved:
Review checklist
Reminder for reviewers