-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom agents #14301
Merged
jfaltermeier
merged 5 commits into
eclipse-theia:master
from
eclipsesource:feat/custom-agents
Oct 18, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7528438
feat: add support for custom agents
eneufeld 9a6fffa
fix issues found by review:
eneufeld 9692ac3
incorporate review comments
eneufeld bf7d7a8
add check during read for unique agent identification
eneufeld 22eaa29
fix to only use id
eneufeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// ***************************************************************************** | ||
// Copyright (C) 2024 EclipseSource GmbH. | ||
// | ||
// This program and the accompanying materials are made available under the | ||
// terms of the Eclipse Public License v. 2.0 which is available at | ||
// http://www.eclipse.org/legal/epl-2.0. | ||
// | ||
// This Source Code may also be made available under the following Secondary | ||
// Licenses when the conditions for such availability set forth in the Eclipse | ||
// Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
// with the GNU Classpath Exception which is available at | ||
// https://www.gnu.org/software/classpath/license.html. | ||
// | ||
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
// ***************************************************************************** | ||
|
||
import { CustomChatAgent } from '../common'; | ||
|
||
export const CustomAgentFactory = Symbol('CustomAgentFactory'); | ||
export type CustomAgentFactory = (id: string, name: string, description: string, prompt: string, defaultLLM: string) => CustomChatAgent; |
73 changes: 73 additions & 0 deletions
73
packages/ai-chat/src/browser/custom-agent-frontend-application-contribution.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// ***************************************************************************** | ||
// Copyright (C) 2024 EclipseSource GmbH. | ||
// | ||
// This program and the accompanying materials are made available under the | ||
// terms of the Eclipse Public License v. 2.0 which is available at | ||
// http://www.eclipse.org/legal/epl-2.0. | ||
// | ||
// This Source Code may also be made available under the following Secondary | ||
// Licenses when the conditions for such availability set forth in the Eclipse | ||
// Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
// with the GNU Classpath Exception which is available at | ||
// https://www.gnu.org/software/classpath/license.html. | ||
// | ||
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
// ***************************************************************************** | ||
|
||
import { AgentService, CustomAgentDescription, PromptCustomizationService } from '@theia/ai-core'; | ||
import { FrontendApplicationContribution } from '@theia/core/lib/browser'; | ||
import { inject, injectable } from '@theia/core/shared/inversify'; | ||
import { ChatAgentService } from '../common'; | ||
import { CustomAgentFactory } from './custom-agent-factory'; | ||
|
||
@injectable() | ||
export class AICustomAgentsFrontendApplicationContribution implements FrontendApplicationContribution { | ||
@inject(CustomAgentFactory) | ||
protected readonly customAgentFactory: CustomAgentFactory; | ||
|
||
@inject(PromptCustomizationService) | ||
protected readonly customizationService: PromptCustomizationService; | ||
|
||
@inject(AgentService) | ||
private readonly agentService: AgentService; | ||
|
||
@inject(ChatAgentService) | ||
private readonly chatAgentService: ChatAgentService; | ||
|
||
private knownCustomAgents: Map<string, CustomAgentDescription> = new Map(); | ||
onStart(): void { | ||
this.customizationService?.getCustomAgents().then(customAgents => { | ||
customAgents.forEach(agent => { | ||
this.customAgentFactory(agent.id, agent.name, agent.description, agent.prompt, agent.defaultLLM); | ||
this.knownCustomAgents.set(agent.id, agent); | ||
}); | ||
}).catch(e => { | ||
console.error('Failed to load custom agents', e); | ||
}); | ||
this.customizationService?.onDidChangeCustomAgents(() => { | ||
this.customizationService?.getCustomAgents().then(customAgents => { | ||
const customAgentsToAdd = customAgents.filter(agent => | ||
!this.knownCustomAgents.has(agent.id) || !CustomAgentDescription.equals(this.knownCustomAgents.get(agent.id)!, agent)); | ||
const customAgentIdsToRemove = [...this.knownCustomAgents.values()].filter(agent => | ||
!customAgents.find(a => CustomAgentDescription.equals(a, agent))).map(a => a.id); | ||
|
||
// delete first so we don't have to deal with the case where we add and remove the same agentId | ||
customAgentIdsToRemove.forEach(id => { | ||
this.chatAgentService.unregisterChatAgent(id); | ||
this.agentService.unregisterAgent(id); | ||
this.knownCustomAgents.delete(id); | ||
}); | ||
customAgentsToAdd | ||
.forEach(agent => { | ||
this.customAgentFactory(agent.id, agent.name, agent.description, agent.prompt, agent.defaultLLM); | ||
this.knownCustomAgents.set(agent.id, agent); | ||
}); | ||
}).catch(e => { | ||
console.error('Failed to load custom agents', e); | ||
}); | ||
}); | ||
} | ||
|
||
onStop(): void { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// ***************************************************************************** | ||
// Copyright (C) 2024 EclipseSource GmbH. | ||
// | ||
// This program and the accompanying materials are made available under the | ||
// terms of the Eclipse Public License v. 2.0 which is available at | ||
// http://www.eclipse.org/legal/epl-2.0. | ||
// | ||
// This Source Code may also be made available under the following Secondary | ||
// Licenses when the conditions for such availability set forth in the Eclipse | ||
// Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
// with the GNU Classpath Exception which is available at | ||
// https://www.gnu.org/software/classpath/license.html. | ||
// | ||
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
// ***************************************************************************** | ||
|
||
import { AgentSpecificVariables, PromptTemplate } from '@theia/ai-core'; | ||
import { AbstractStreamParsingChatAgent, ChatAgent, SystemMessageDescription } from './chat-agents'; | ||
import { injectable } from '@theia/core/shared/inversify'; | ||
|
||
@injectable() | ||
export class CustomChatAgent | ||
extends AbstractStreamParsingChatAgent | ||
implements ChatAgent { | ||
name: string; | ||
description: string; | ||
readonly variables: string[] = []; | ||
readonly functions: string[] = []; | ||
readonly promptTemplates: PromptTemplate[] = []; | ||
readonly agentSpecificVariables: AgentSpecificVariables[] = []; | ||
|
||
constructor( | ||
) { | ||
super('CustomChatAgent', [{ purpose: 'chat' }], 'chat'); | ||
} | ||
protected override async getSystemMessageDescription(): Promise<SystemMessageDescription | undefined> { | ||
const resolvedPrompt = await this.promptService.getPrompt(`${this.name}_prompt`); | ||
return resolvedPrompt ? SystemMessageDescription.fromResolvedPromptTemplate(resolvedPrompt) : undefined; | ||
} | ||
|
||
set prompt(prompt: string) { | ||
this.promptTemplates.push({ id: `${this.name}_prompt`, template: prompt }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are already custom agents then this should be called "Edit Custom Agents" as it does no longer add one