Add support for o1-preview #14356
Add support for o1-preview #14356
Conversation
JonasHelming
requested review from
sdirix and
planger
and removed request for
sdirix
| identifier: 'openai/o1-preview', | ||
| }], | ||
| 'chat', | ||
| 'codicon codicon-chat', |
There was a problem hiding this comment.
I think codicon-chat doesn't exist.
| ChatAgentLocation.ALL, | ||
| ['Chat'], | ||
| true |
There was a problem hiding this comment.
I think we could just remove those as they are just replicating the defaults of the super class.
| this.agentSpecificVariables = []; | ||
| this.variables = []; |
There was a problem hiding this comment.
Imho it'd be clearer if we just initialize them above (as agentSpecificVariables is already initialized with an empty array). So we could just remove those lines.
| public name = 'O1-Preview'; | ||
| public description = 'An agent for interacting with ChatGPT o1-preview'; | ||
| public promptTemplates: PromptTemplate[] = []; | ||
| public defaultModel = 'o1-preview'; |
There was a problem hiding this comment.
This doesn't appear to be used anywhere is it?
| @@ -0,0 +1,46 @@ | |||
| import { | |||
There was a problem hiding this comment.
There are a few linting errors in this file (no copyright, extra blank lines).
There was a problem hiding this comment.
With 6546049 I've suggested a fix for my comments. With them in, this change is good to go imho!
At first it was a bit surprising to see a dedicated chat agent, but since o1 has a different interaction model (no streaming, no system message, maybe in the future more progress reporting), I guess it is justified.
Works great, thank you!
fixed #14329 Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
force-pushed
the
GH-14329
branch
from
6546049 to
a1ec8ca
Compare
fixed #14329
What it does
Adds a new agent O1-Preview to chat with o1
How to test
Select o1-preview for the O1 agents and ask it questions.
Review checklist
Reminder for reviewers