Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed overlapping of outputs when creating a cell at the top #14417

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Fix a bug that happened when creating a cell at the very top of the notebook which caused the next cell to overlap its output.

How to test

Open or Create a notebook.
Ensure the first cell has output rendered.
Create a cell above it.
This should still all look fine

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden requested a review from msujew November 8, 2024 09:09
@msujew msujew added the notebook issues related to notebooks label Nov 11, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jonah-iden jonah-iden merged commit c028a03 into master Nov 11, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 11, 2024
@jonah-iden jonah-iden deleted the jiden/notebook-fix-creating-first-cell-overlaps branch November 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants