Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: still use settings and configuration from the local user dir #14548

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Nov 28, 2024

What it does

This makes it so that when connected to a remote system or dev-container, configuration from the user dir like tasks, settings, ai-prompts, etc. are still used instead of the configurations located on the remote system/container.

Fixes #14291

How to test

Connect to a remote system and see you theme, settings etc are still all set to what they were before connecting.

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix. Works really well and my settings are now correctly applied. It does however not fix the issue with the terminal on my end (but this should not be a blocker for this).

Also i added 2 minor comments, where i would like to have your input.

@jonah-iden
Copy link
Contributor Author

Thanks for testing the terminal issue. I'll take another look at that

@jonah-iden
Copy link
Contributor Author

jonah-iden commented Nov 29, 2024

are you sure this does not work with the terminal. Adding and removing this in the settings works absolutely fine for me

    "terminal.integrated.defaultProfile.linux": "bash",
    "terminal.integrated.profiles.linux": {
        "bash": {
            "path": "/bin/bash"
        },
    },

Or just switching the defualtProfile.linux between bash and SHELL works fine as well

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this does not work with the terminal. Adding and removing this in the settings works absolutely fine for me

With the options you provided it works, however i am talking about the case that the user does not have this setting set (as i do for example). In VSCode i then still get a bash terminal by default in the devcontainer. In theia it is just a plain shell. Is there a default value that we could set differently?

However, if not a really quick fix, this is not part of this ticket anymore. For the promised functionality i tested it and everything works great! Thanks a lot 🎉

@jonah-iden jonah-iden merged commit 66c1b9d into master Dec 3, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/remote-use-local-user-dir-settings- branch December 3, 2024 14:45
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 3, 2024
@jfaltermeier
Copy link
Contributor

Just an FYI, this doesn’t seem to work on the Theia IDE Preview for 1.57 at the moment. We haven’t investigated yet: #14643 (comment)

@jonah-iden
Copy link
Contributor Author

thanks for the info, i started investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

User settings not applied in dev containers
3 participants