-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote: still use settings and configuration from the local user dir #14548
Conversation
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the fix. Works really well and my settings are now correctly applied. It does however not fix the issue with the terminal on my end (but this should not be a blocker for this).
Also i added 2 minor comments, where i would like to have your input.
Thanks for testing the terminal issue. I'll take another look at that |
are you sure this does not work with the terminal. Adding and removing this in the settings works absolutely fine for me
Or just switching the defualtProfile.linux between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this does not work with the terminal. Adding and removing this in the settings works absolutely fine for me
With the options you provided it works, however i am talking about the case that the user does not have this setting set (as i do for example). In VSCode i then still get a bash
terminal by default in the devcontainer. In theia it is just a plain shell. Is there a default value that we could set differently?
However, if not a really quick fix, this is not part of this ticket anymore. For the promised functionality i tested it and everything works great! Thanks a lot 🎉
Just an FYI, this doesn’t seem to work on the Theia IDE Preview for 1.57 at the moment. We haven’t investigated yet: #14643 (comment) |
thanks for the info, i started investigating |
What it does
This makes it so that when connected to a remote system or dev-container, configuration from the user dir like tasks, settings, ai-prompts, etc. are still used instead of the configurations located on the remote system/container.
Fixes #14291
How to test
Connect to a remote system and see you theme, settings etc are still all set to what they were before connecting.
Follow-ups
Review checklist
Reminder for reviewers