On darwin/arm64 force docker to pull amd64 image #14552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc.: @JonasHelming |
jbicker
changed the title
jonah-iden
approved these changes
Nov 29, 2024
| @@ -167,6 +167,8 @@ export class RemoteSetupService { | |||
| arch = 'x64'; | |||
| } else if (archResult.match(/i\d83/)) { // i386, i483, i683 | |||
| arch = 'x86'; | |||
| } else if (archResult.includes('aarch64')) { | |||
There was a problem hiding this comment.
do we even still need this? But i guess it can't hurt to already have it for whenwe get the arm64 dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Using dev containers on a Mac with ARM architecture is currently only possible by pulling an image for AMD64 architecture.
This workaround checks respective combination (darwin/arm64) and forces Docker to pull a AMD64 image.
Note: DevContainer could work a bit slow but at least it will.
How to test
Get yourself a Mac with at least a M1 chip. :-)
Start theia as Electron app and connect to a dev container.
Review checklist
Reminder for reviewers