fix: scanoss error on Windows #14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the scanoss library returns its results in a different shape than on the other platforms. We now anticipate this behavior. fixes eclipse-theia#14648
tsmaeder
approved these changes
Dec 19, 2024
jfaltermeier
pushed a commit
that referenced
this pull request
Dec 19, 2024
On Windows, the scanoss library returns its results in a different shape than on the other platforms. We now anticipate this behavior. fixes #14648
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
On Windows, the scanoss library returns its results in a different shape than on the other platforms. We now anticipate this behavior.
fixes #14648
How to test
Try to execute the SCANOSS actions on Windows. For this you need to set SCANOSS to "manual" or "automatic" in the preferences.
Follow-ups
This should be fixed in the scanoss library as this is likely not the intended behavior. Once we consume that new version we can remove the workaround again.
Breaking changes
Review checklist
Reminder for reviewers