Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix drag file with err uri #14746

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

yanquer
Copy link
Contributor

@yanquer yanquer commented Jan 20, 2025

What it does

when drag file, no use fromComponents which cause error-formated-str with #14724

How to test

  • in windows, custom a event to read file which drag to , using FileService. (example)

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@yanquer yanquer mentioned this pull request Jan 20, 2025
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yanquer, thank you for the contribution!

In order to accept your changes, please sign the Eclipse Contributor Agreement (ECA) with the same email address that was used to create the commit.

packages/core/src/browser/shell/application-shell.ts Outdated Show resolved Hide resolved
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yanquer, looks good to me 👍

@msujew msujew merged commit ecf65d3 into eclipse-theia:master Jan 22, 2025
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants