Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-568: Bumped up Yarn version from 1.0.2 to 1.2.1. #710

Merged
merged 4 commits into from
Oct 24, 2017
Merged

GH-568: Bumped up Yarn version from 1.0.2 to 1.2.1. #710

merged 4 commits into from
Oct 24, 2017

Conversation

kittaakos
Copy link
Contributor

Closes #568.

Signed-off-by: Akos Kitta [email protected]

@kittaakos
Copy link
Contributor Author

@akosyakov, @hexa00, please review ASAP, otherwise we cannot proceed with other PRs due to the broken Windows build. Thank you!

@hexa00
Copy link

hexa00 commented Oct 23, 2017

Could you add maybe in the doc a comment about: yarnpkg/yarn#4695

The user will see errors while building with 1.2.1, maybe point to the issue and say we can ignore those errors?

otherwise LGTM. thx

@kittaakos
Copy link
Contributor Author

Could you add maybe in the doc a comment about: yarnpkg/yarn#4695

Please link the desired location, I'll add it. Thanks!

@hexa00
Copy link

hexa00 commented Oct 23, 2017 •
edited
Loading

I did provide the link already ? :) yarnpkg/yarn#4695

If you mean in the doc it could be in troubleshooting

@kittaakos
Copy link
Contributor Author

I did provide the link already ? :) yarnpkg/yarn#4695

:) OK, but where should I put this in our documentation. Did I misunderstand you?

@hexa00
Copy link

hexa00 commented Oct 23, 2017

In Troubleshooting I think would be ok with like:

With yarn 1.2.1 you will see these errors...

Don't worry about it.

@kittaakos
Copy link
Contributor Author

Cheers!

@kittaakos kittaakos requested review from hexa00 and akosyakov October 23, 2017 16:08
hexa00
hexa00 approved these changes Oct 23, 2017
View reviewed changes
Copy link

@hexa00 hexa00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akosyakov
akosyakov approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge

@kittaakos kittaakos merged commit 6aef474 into master Oct 24, 2017
@kittaakos kittaakos deleted the GH-568 branch October 24, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexa00 hexa00 hexa00 approved these changes

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @hexa00 @akosyakov