Add command Copy Path and bind handler for native VS Code command

[vzhukovs]

What it does

This changes proposal provides ability to copy absolute path to the file. This can be reached by calling Copy Path item in context menu of explorer or opened editor. Also, this proposal provides additional command copyFilePath, which is bridge between Theia and VS Code extension [1].

[1] microsoft/vscode/src/vs/workbench/contrib/files/browser/fileCommands.ts#L247-L259

Use case 1.
Copy Path call from Project Explorer:

Use case 2.
Copy Path call from Opened Editor:

Use case 3.
Call VS Code's command copyFilePath from third-party plugin:

Use case 4.
Call VS Code's command copyFilePath from third-party plugin when everything hidden:

Needed for Didact extension, but temporary can't be reached in the last one because of dependent issue. So there is another way to check this PR.

Signed-off-by: Vladyslav Zhukovskyi [email protected]

How to test

Plugin to check the changes can be reached here.
For the calling items from context menus, it's enough to build Theia from the PR and try to copy file path.

Review checklist

• Need to check on windows hotkey combination shift+alt+c, because of lack windows machine I can't be 100% sure, that this hotkey is free.

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[azatsarynnyy]

I've checked all the described use cases. Works well.
Thanks for providing the test plugin!

[kittaakos]

Use case 2.
Copy Path call from Opened Editor:

@vzhukovskii, VS Code does not provide a dedicated context-menu item for copying the file path, did you add it intentionally? Can we get rid of it? It would be great to keep the context menu aligned with VS Code and not to end up in a gigantic one with all actions just because we can add it there. What do you think? Also, the keybinding you have defined has a collision with Cmd+Alt+C Match Case in the find widget.

[kittaakos]

Since this change does not work on macOS (due to the Match Case of the Find/Replace widget), I tend to revert it. It would be great if you could prepare a follow-up PR without the context menu addition for the editor. Thoughts?

See the screencast:

• I put something to the clipboard before executing Copy Path,
• I still have my input on the clipboard instead of the path after executing Copy Path.

[kittaakos]

without the context menu addition for the editor.

We do not need the keybinding either.

[kittaakos]

@vzhukovskii, @azatsarynnyy ping?

[1] microsoft/vscode/src/vs/workbench/contrib/files/browser/fileCommands.ts#L247-L259

It seems the VS Code implementation has a when condition for the keybinding, this PR does not define any when for the keybinding.

[akosyakov]

@vzhukovskii Could you follow up on @kittaakos feedback please? 🙏

[kittaakos]

Guys, I am going to wait till next week and will create a revert commit afterward.

[vzhukovs]

@kittaakos, @akosyakov sorry for the late response, wasn't able to respond these days.

VS Code does not provide a dedicated context-menu item for copying the file path, did you add it intentionally?

Yes, it was added intentionally. We can move this item menu from editor context menu to the editor's tab context menu. As in VS Code, there is such item.

Agree, from the editor context menu it should be moved away.

We do not need the keybinding either.

I can remove keybinding at all, is this sounds good? I think, keybinding should work, when !editorFocus will be added.

[kittaakos]

As in VS Code, there is such item.

I see, so they put it there. Yes, it would be nice to do what VS Code does.

I can remove keybinding at all, is this sounds good?

Sounds good to me, but as you wrote adding the proper when would be the best, so we would be 100% VS Code compliant 💪 No hurry on the fixes, just let's not forget about this inconsistency. Thank you!

[vzhukovs]

I see, so they put it there. Yes, it would be nice to do what VS Code does.

Good, I'll prepare a PR to move item from the current place to editor's tab.

but as you wrote adding the proper when would be the best, so we would be 100% VS Code compliant

This need to be checked and if there isn't any odd behavior, I'll include when condition to it. I didn't check the behavior of the keybinding inside opened editor, only when focus was in navigator and when there wasn't any part opened. My fault.

[kittaakos]

Good, I'll prepare a PR

🙏 Thank you! Feel free to name me if you need someone for the review.

only when focus was in navigator and when there wasn't any part opened. My fault.

No worries at all; it happens.