-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RPCProtocol #8972
Refactor RPCProtocol #8972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand the system, but so far those changes are looking good to me.
@marechal-p thx for the review. |
Hello, I still don't get the real benefits, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see regression using Theia
@tsmaeder merge at will. |
@marechal-p Not merging because of downstream reasons 🤷 . |
72dd264
to
1025a94
Compare
1025a94
to
5128136
Compare
5128136
to
8b93e69
Compare
8b93e69
to
d44b0a4
Compare
Signed-off-by: Thomas Mäder <[email protected]>
d44b0a4
to
dbf86d2
Compare
What it does
This refactoring clarifies an decouples a bunch of things. This is a pure refactoring which should not change behaviour.
How to test
Run Theia with with at least a back-end and one front-end plugin. No exceptions related to rpc processing should appear in neither the back-end nor front-end logs.
Note: front-end plugins still don't work with electron.
Review checklist
Reminder for reviewers