Bump API version to 1.53.2 #9959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
| @@ -14,5 +14,5 @@ | |||
| * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | |||
| ********************************************************************************/ | |||
|
|
|||
| export const VSCODE_DEFAULT_API_VERSION = '1.50.0'; | |||
| export const VSCODE_DEFAULT_API_VERSION = '1.53.2'; | |||
There was a problem hiding this comment.
@tsmaeder as part of the bump, should we also think about bumping our versions of the builtins (so we make use of the latest api). In theory we can now consume the vscode-builtin-extension-pack and use the mechanism of #9956 to exclude plugins we don't want (ex: vscode-git at the moment).
There was a problem hiding this comment.
@vince-fugnitto those are all worthy goals, but IMO not reasons to delay the merging of this PR. Testing through the built-ins (and changing the mechanism to consume them) would take considerable time and is not part of the issue this PR is fixing.
msujew
approved these changes
Aug 30, 2021
2 tasks
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Signed-off-by: Thomas Mäder <[email protected]>
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Signed-off-by: Thomas Mäder <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder [email protected]
What it does
Bumps the default vscode API version to 1.53.2. The linked issue proposes 1.52.0, but I believe the the changes between 1.52.0 and 1.53.2 should be binary compatible or already implemented in theia (see
SecretsStorage).#9193
How to test
I tested by starting VS Code Java 0.81
Review checklist
Reminder for reviewers