Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batching to stable. #850

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Conversation

jean-roland
Copy link
Contributor

This PR fixes the few issues that prevented manual batching to be stable:

  • is_express qos should trigger an immediate batch send.
  • keep alive, close and other transport messages should be sent immediately.

Copy link

github-actions bot commented Jan 6, 2025

PR missing one of the required labels: {'bug', 'documentation', 'enhancement', 'breaking-change', 'dependencies', 'internal', 'new feature'}

@jean-roland jean-roland added the enhancement Things could work better label Jan 6, 2025
@jean-roland jean-roland requested a review from sashacmc January 6, 2025 15:29
src/protocol/codec/network.c Outdated Show resolved Hide resolved
@jean-roland jean-roland requested a review from sashacmc January 7, 2025 09:36
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small syntax sugar, others LGTM

src/transport/common/tx.c Outdated Show resolved Hide resolved
@gabrik gabrik merged commit 2514041 into eclipse-zenoh:main Jan 7, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants