Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow serializer overriding #320

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: allow serializer overriding #320

merged 2 commits into from
Sep 17, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Sep 16, 2024

No description provided.

@wyfo wyfo added enhancement Things could work better new feature Something new is needed labels Sep 16, 2024
@wyfo wyfo requested a review from Mallets September 17, 2024 06:04
@Mallets
Copy link
Member

Mallets commented Sep 17, 2024

This PR LGTM.

Before merging, are you planning to address #318 in this PR or in a separate PR?

@Mallets
Copy link
Member

Mallets commented Sep 17, 2024

Closes #284

@wyfo
Copy link
Contributor Author

wyfo commented Sep 17, 2024

Before merging, are you planning to address #318 in this PR or in a separate PR?

Separate PR.

@Mallets Mallets merged commit 9bfe673 into eclipse-zenoh:main Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
enhancement Things could work better new feature Something new is needed
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyfo @Mallets