Draft: Add new_timestamp to Session
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
reviewed
Jun 20, 2024
zenoh/src/api/session.rs
Outdated
| /// ``` | ||
| pub fn new_timestamp(&self) -> Timestamp { | ||
| let id = self.runtime.zid(); | ||
| // TODO: Should we make this an Result return type ? |
There was a problem hiding this comment.
duration_since(UNIX_EPOCH) should never fail since SystemTime is not allowed to be earlier than UNIX_EPOCH.
Charles-Schleich
changed the title
new_timestamp to Sessionnew_timestamp to Session
milyin
reviewed
Jun 21, 2024
| @@ -15,6 +15,7 @@ use std::time::{SystemTime, UNIX_EPOCH}; | |||
|
|
|||
| use zenoh_protocol::core::{Timestamp, TimestampId}; | |||
|
|
|||
| // TODO: Shall we remove this new_timestamp in favoir of the src/api/session::Session::new_timestamp(); | |||
There was a problem hiding this comment.
Yes, there was discussion about it, created issue #1179
milyin
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.