Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value fields public #1178

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

Charles-Schleich
Copy link
Member

@Charles-Schleich Charles-Schleich commented Jun 20, 2024

Make fields of Value public now that now that value is behind feature flag internal
#1125

This would remove need to clone fields when you want to separate out payload and encoding

@milyin
Copy link
Contributor

milyin commented Jun 21, 2024

Approved, but it's better to finally get rid of value completely

@milyin milyin merged commit 65e5df7 into eclipse-zenoh:dev/1.0.0 Jun 21, 2024
12 checks passed
@skreborn
Copy link

skreborn commented Jul 9, 2024

Approved, but it's better to finally get rid of value completely

Apologies if this is not the place to enquire, but is that planned for the 1.0.0 release? I'm using Value in various places in our codebase and would love to know what's coming so I can better prepare. Happy to move this to a separate discussion if that's preferred.

@Charles-Schleich
Copy link
Member Author

Charles-Schleich commented Jul 10, 2024

@skreborn for the moment it is not planned for the 1.0.0 release.
For Zenoh users there will be some refactoring needed as we have made Value an internal struct
When the official 1.0.0 release happens, we will also release a migration guide.

@Charles-Schleich Charles-Schleich deleted the dev/1.0.0_value branch August 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants