Add verification function when saving #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abliger
commented
Jan 24, 2024
ecmel
reviewed
Jan 25, 2024
package.json
Outdated
| "vscode-html-css.vaildOnSave": { | ||
| "type": "boolean", | ||
| "description": "Verify label class names when saving files.", | ||
| "scope": "application", |
There was a problem hiding this comment.
Better to be resource (workspace) scopped and be an enum for future. (Like On save, On change etc)
ecmel
reviewed
Jan 25, 2024
src/extension.ts
Outdated
| @@ -27,8 +27,13 @@ export function activate(context: ExtensionContext) { | |||
| workspace.onDidCloseTextDocument((document) => | |||
| validations.delete(document.uri) | |||
| ), | |||
| workspace.onDidChangeTextDocument((event) => | |||
| validations.delete(event.document.uri) | |||
| workspace.onDidChangeTextDocument(async (event) => { | |||
There was a problem hiding this comment.
This should be according to the settings, such as on save on change etc.
There was a problem hiding this comment.
I also discovered this issue today and will submit it later
ecmel
reviewed
Jan 25, 2024
| @@ -16,3 +16,9 @@ export function getStyleSheets(uri: Uri): string[] { | |||
| .getConfiguration("css", uri) | |||
| .get<string[]>("styleSheets", []); | |||
| } | |||
|
|
|||
| export function getVaildOnSave(): Boolean { | |||
| return workspace | |||
There was a problem hiding this comment.
Should be resource scopped like styleSheets
|
Thank you for the PR 👍 |
abliger
commented
Jan 26, 2024
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.