Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: Fix handling of external module procedures #263

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

reuterbal
Copy link
Collaborator

Procedures in missing modules (that are recognized as ExternalItem) were not recognized as ExternalItems and instead created as ProcedureItem with missing source. This fixes that erroneous behaviour.

@reuterbal reuterbal requested a review from mlange05 March 27, 2024 10:33
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/263/index.html

@reuterbal reuterbal changed the title Fix handling of external module procedures Scheduler: Fix handling of external module procedures Mar 27, 2024
@reuterbal
Copy link
Collaborator Author

Piggy-backed a small fix to the regex frontend: functions with a kind-specifier and return-type declaration in the prefix (i.e., = in the function prefix), wouldn't match if embedded in a module. modified an existing test accordingly

@reuterbal reuterbal force-pushed the nabr-fix-external-module-procedures branch from 6423a6b to 634e516 Compare March 27, 2024 12:47
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. GTG :shipit:

@reuterbal reuterbal merged commit 0a15267 into main Mar 27, 2024
11 checks passed
@reuterbal reuterbal deleted the nabr-fix-external-module-procedures branch March 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants