Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid variable_map in TypedSymbol.get_derived_type_member and verify type information is derived correctly #285

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

reuterbal
Copy link
Collaborator

I played around a little with this because I wanted to see if we can get away without using the symbol's variable_map, which can be costly for large and nested derived types. For this, I've also added an additional test that validates that type information is derived correctly.

@reuterbal reuterbal requested a review from awnawab April 11, 2024 18:56
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/285/index.html

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (03170f5) to head (20496ab).

Additional details and impacted files
@@                Coverage Diff                @@
##           naan-stack-fixes     #285   +/-   ##
=================================================
  Coverage             92.88%   92.88%           
=================================================
  Files                   102      102           
  Lines                 18267    18266    -1     
=================================================
  Hits                  16967    16967           
+ Misses                 1300     1299    -1     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 92.85% <100.00%> (+<0.01%) ⬆️
transformations 92.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awnawab awnawab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the type information is looked in the Variable factory method via the parent? Very clever! many thanks for this!

@awnawab awnawab merged commit 6746752 into naan-stack-fixes Apr 11, 2024
12 checks passed
@awnawab awnawab deleted the nabr-naan-stack-fixes branch April 11, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants