Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation to hoist temporaries in kernel language transpilation #291

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

MichaelSt98
Copy link
Collaborator

hoisting arrays via pragma offload for low-level GPU implementations (no block index, which makes it different to SCCHoistTemporaryArraysTransformation)

…ia pragma offload for low-level GPU implementations (no block index)
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/291/index.html

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (3e555d5) to head (a6bd653).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   94.92%   94.95%   +0.03%     
==========================================
  Files         152      153       +1     
  Lines       31421    32052     +631     
==========================================
+ Hits        29827    30436     +609     
- Misses       1594     1616      +22     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.12% <ø> (+0.02%) ⬆️
transformations 92.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuterbal reuterbal changed the title 'HoistTemporaryArraysPragmaOffloadTransformation' Transformation to hoist temporaries in kernel language transpilation Apr 18, 2024
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I think the list of variables to be added should be compiled in full before adding it to the routine, instead of adding them 1-by-1, otherwise good to go from me.

transformations/transformations/scc_cuf.py Outdated Show resolved Hide resolved
@reuterbal reuterbal merged commit 102655b into main Apr 18, 2024
12 checks passed
@reuterbal reuterbal deleted the nams_hoist_variables_pragma_offload branch April 18, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants