Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scoping for global var hoisting #293

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

MichaelSt98
Copy link
Collaborator

fix scoping for GlobalVarHoistTransformation'

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/293/index.html

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (102655b) to head (a0caaa1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         153      153           
  Lines       32052    32052           
=======================================
  Hits        30436    30436           
  Misses       1616     1616           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.12% <ø> (ø)
transformations 92.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice find!

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Apr 19, 2024
@reuterbal reuterbal merged commit 59303e4 into main Apr 19, 2024
12 checks passed
@reuterbal reuterbal deleted the nams_global_var_hoist_scope branch April 19, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants