Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch tags in Github workflows #305

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fetch tags in Github workflows #305

merged 1 commit into from
Apr 30, 2024

Conversation

reuterbal
Copy link
Collaborator

Small bugfix PR: The GH workflows did not fetch tags in the clone, therefore the Loki version number was always wrong (including in the published docs).

@reuterbal reuterbal requested a review from mlange05 April 30, 2024 11:55
@reuterbal reuterbal force-pushed the nabr-gh-fetch-tags branch from 24be98a to 665ba23 Compare April 30, 2024 11:57
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/305/index.html

This resolves the wrong Loki version annotation due to missing git
history. See pypa/setuptools-scm#480.
@reuterbal reuterbal force-pushed the nabr-gh-fetch-tags branch from 665ba23 to e9b4bca Compare April 30, 2024 12:23
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (0e011a0) to head (e9b4bca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         151      151           
  Lines       32407    32407           
=======================================
  Hits        30779    30779           
  Misses       1628     1628           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.13% <ø> (ø)
transformations 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :shipit:

@reuterbal reuterbal merged commit cdca701 into main Apr 30, 2024
12 checks passed
@reuterbal reuterbal deleted the nabr-gh-fetch-tags branch April 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants