Fix: import of private symbols affects the type inference #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quepas
changed the title
quepas
force-pushed
the
no_import_private_symbols
branch
2 times, most recently
from
4b456b1 to
2b55a60
Compare
quepas
force-pushed
the
no_import_private_symbols
branch
from
7cb154d to
c5488e6
Compare
reuterbal
requested changes
May 3, 2024
reuterbal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 165 165
Lines 35282 35301 +19
=======================================
+ Hits 33552 33571 +19
Misses 1730 1730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
quepas
force-pushed
the
no_import_private_symbols
branch
from
c5488e6 to
f6d98b7
Compare
quepas
force-pushed
the
no_import_private_symbols
branch
from
f6d98b7 to
9b8ac61
Compare
Thank you for great suggestions! I have applied them. No problem, the pleasure is on our side (IPSL), as we are actively using loki in our work. |
reuterbal
approved these changes
May 6, 2024
reuterbal
added
the
ready to merge
|
ecwam regression fails due to missing permissions from an external contribution. Verified compatibility offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #309, imports of private symbols destroys the type inference. This pull request propose a simple check of symbols access specificators to filter out the private symbols.
TODO: